Open mswartzCL opened 2 years ago
I don't think we need to validate the context metadata and provide feedback (e.g. showing error icons) when creating an experiment though the stepper UI because the fields that need validation (e.g. Site, Target, Condition) can be completed using the combo box, and the available options will be pulled from the metadata so it guarantees the validation anyway (unless the user intentionally wants to use invalid values). So I think we should validate an experiment and provide feedback after it is created or updated (in the detail page), and not during the creation or editing process (in the stepper UI).
@zackcl Based on our conversation today about validation in the stepper and edit modals vs. displayed on the experiment detail, I am going to refine and combine stories #402 and #403.
@zackcl What do you think about this user story now?
@mswartzCL Thanks for updating the story. I think that looks good although I think we might want to still let the user know if the Context Metadata for an AppContext does not exist while the validation checkbox is enabled. Maybe we can show an error icon next to the experiment name (just like when validation failed) to indicate that something is wrong. Otherwise, the user might think that the Context Metadata exists and has been validated.
User Story
Acceptance Criteria
Scenario: Context Metadata does not exist for AppContext
Scenario: Context Metadata validation is disabled globally
Scenario: Context Metadata exists for AppContext
Design - Link to design
Context Metadata Model Context Metadata Gist