CarnetApp / CarnetNextcloud

GNU Affero General Public License v3.0
154 stars 29 forks source link

Did Nextcloud update (20.0.5) break Carnet? #143

Closed jcm4atx closed 3 years ago

jcm4atx commented 3 years ago

Describe the bug Only able to install Carnet from source and then I just see a blank screen, not Carnet.

To Reproduce Steps to reproduce the behavior:

  1. Unable to install Carnet from the web-based App Store. Get "Could not extract app carnet".
  2. Unable to install at command line with sudo -u www-data php ./occ app:install carnet. Get "Could not extract app carnet".
  3. Was able to install by downloading and installing the source:
    cd /tmp
    wget https://github.com/CarnetApp/CarnetNextcloud/archive/master.zip
    unzip master.zip
    mv CarnetNextcloud-master/ carnet
    sudo chown -R www-data: carnet/
    sudo mv carnet/ /var/www/html/apps/
    cd /var/www/html
    sudo -u www-data php ./occ app:enable carnet

    but only get a blank screen. I did restart Apache for good measure.

Expected behavior I expect the main screen with the fake notes.

Desktop (please complete the following information):

tofublock commented 3 years ago

I see the same behaviour. "Could not extract app carnet" both from browser and occ. I'm on a fresh install of NC20.0.6 with Apache in Docker with a reverse proxy in front of it. When I manually install from zip I get a blank page and an exception in log about CarnetElectron.

Does anybody know more?

EDIT: I do! To install Carnet from git you also have to resolve the CarnetElectron dependency. One way to do it would be to clone the repo recursively (git clone https://github.com/CarnetApp/CarnetNextcloud.git --recursive) or - as I did just now - to unzip Carnet and unzip CarnetElectron (https://github.com/PhieF/CarnetElectron.git) into carnet/templates/CarnetElectron. After that it works for me.

tofublock commented 3 years ago

It would be cool to be able to install install through the app store. Could the submodule be the culprit here?

robert-elles commented 3 years ago

Same for me. I see the following stacktrace in the logs:

[settings] Error: Exception: Could not extract app carnet at <>

  1. /data/nextcloud/apps/settings/lib/Controller/AppSettingsController.php line 445 OC\Installer->downloadApp("carnet")
  2. /data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 169 OCA\Settings\Controller\AppSettingsController->enableApps(["carnet"], [])
  3. /data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 100 OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings\Con ... {}, "enableApps")
  4. /data/nextcloud/lib/private/AppFramework/App.php line 152 OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings\Con ... {}, "enableApps")
  5. /data/nextcloud/lib/private/Route/Router.php line 309 OC\AppFramework\App::main("OCA\Settings\ ... r", "enableApps", OC\AppFramework\ ... {}, {_route: "settin ... "})
  6. /data/nextcloud/lib/base.php line 1008 OC\Route\Router->match("/settings/apps/enable")
  7. /data/nextcloud/index.php line 37 OC::handleRequest()
callahan22 commented 3 years ago

To add to this...

Describe the bug Failure to install. "An error occured during the request. Unable to proceed. Could not extract app carnet"

To Reproduce Steps to reproduce the behavior:

  1. Try to install the app from the App repo built into Nextcloud.

Expected behavior The app installed.

Desktop (please complete the following information):

Nextcloud log file: {"reqId":"DwV2UEu8EmnhSCMjjJhh","level":3,"time":"February 09, 2021 12:46:19","remoteAddr":"192.168.1.24","user":"user","app":"settings","method":"POST","url":"/settings/apps/enable","message":{"Exception":"Exception","Message":"Could not extract app carnet","Code":0,"Trace":[{"file":"/config/www/nextcloud/apps/settings/lib/Controller/AppSettingsController.php","line":445,"function":"downloadApp","class":"OC\\Installer","type":"->"},{"file":"/config/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"enableApps","class":"OCA\\Settings\\Controller\\AppSettingsController","type":"->"},{"file":"/config/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/config/www/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/config/www/nextcloud/lib/private/Route/Router.php","line":309,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/config/www/nextcloud/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/config/www/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/config/www/nextcloud/lib/private/Installer.php","Line":297,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.152 Safari/537.36","version":"20.0.7.1"}

diqidoq commented 3 years ago

Possibly related -> https://github.com/CarnetApp/CarnetNextcloud/issues/145

fuzz500 commented 3 years ago

Carnet failed to install on NextCloud 20 via the App Store.

I did a fresh install of Ubuntu 20.04 on a Digital Ocean droplet. I did "snap install nextcloud". When I logged into the NextCloud as administrator, go to app store, select Carnet, got "Could not extract app carnet".

I did a new install of Ubuntu 20.04 did a "snap install nextcloud --channel=19/stable". logged in as admin, went to app store, select Carnet. Installed perfectly.

If you have an existing NC19 install, and do a snap upgrade to upgrade to NC20, and Carnet will still work. I did this on another machine.

It would appear the problem is not with running the code on NC20, but installing on NC20.

diqidoq commented 3 years ago

Good finding. +1 @fuzz500

PhieF commented 3 years ago

It should install properly with latest carnet version ! :) if somebody wants to confirm

thanks for your reports and investigations !

callahan22 commented 3 years ago

It's alive!

All good. Thanks for resolving :-)

PhieF commented 3 years ago

Haha sorry I didn't have time to work a lot on this

I'm closing this issue