search

CarnetApp / CarnetNextcloud

GNU Affero General Public License v3.0
153 stars 28 forks source link

Please add compatibility with Nextcloud V23 #173

Open leonardohlee opened 2 years ago

leonardohlee commented 2 years ago

Please add compatibility with Nextcloud V23

phatair commented 2 years ago

Is there an Update coming or is the project "dead"? That would be very sad because the app is very useful.

PhieF commented 2 years ago

Not dead, quite hard to dev right now but I'm trying to get back to it

phatair commented 2 years ago

Thanks a lot PhieF! I appreciate the great work!

Apfelwurm commented 2 years ago

I quickly took a look into the current app upgrade guide and checked if there is anything used here that has changed since 22 and that seems not to be the case. There were only changes made in \OCP\User\Events\UserLoggedInEvent::getPassword and the old calendar api \OCP\Calendar\IManager was deprecated. So i guess, without testing, you should be just able to bump the supported Version :)

sebthesun commented 2 years ago

@PhieF if you need help for anything, do not hesitate.

PhieF commented 2 years ago

So I checked yesterday, it will require a bit of work since they've changed some css that affect Carnet, I'm planning on putting the whole app inside an iframe so I need to check for bugs before releasing, it might break some things

PhieF commented 2 years ago

shoud be ok now !

Miyamoto72 commented 2 years ago

Works fine with NC 23 here, but NC 24 is coming up and so far no compatibility tagged in NC app store. Just upgraded to NC 24beta3 and enabled Carnet. Seems to work, but I did no extensive testing so far.

Makeitlviv commented 2 years ago

The same issue: please, update app to be compatible with NC 24.

Zyclotrop-j commented 1 year ago

carnet_nextcloud26 Same thing, please update app to be compatible with NC 26.

GTP95 commented 1 year ago

I think this issue can be closed, as I'm using Carnet on Nextcloud 26.0.1 and it is working so far. I'm also not the only one, see issue #203. The only thing left to do is to indicate that the app is compatible with Nextcloud 26, so that it doesn't show up as an unverified app.