CarnetApp / CarnetNextcloud

GNU Affero General Public License v3.0
153 stars 28 forks source link

Nextcloud 25 compatibility #198

Closed zurchpet closed 1 year ago

zurchpet commented 1 year ago

Carnet does not work on Nextcloud Version 25.

MartinixH commented 1 year ago

as "hotfix" I commented out every line starting with 'app_version' in /var/www/html/nextcloud/custom_apps/carnet/lib/Controller/PageController.php

and lines 244-248 and 251 in /var/www/html/nextcloud/custom_apps/carnet/lib/Controller/NoteController.php

then it started working, but it print errors in nextcloud.log that 'app_version' variable is not set. So it's not final solution, but it works

zurchpet commented 1 year ago

Thanks @MartinixH I'll give it a try.

zurchpet commented 1 year ago

Cool. I can confirm, that the modifications @MartinixH suggested did make it work again.

T0ytoy commented 1 year ago

Thanks for the hack @MartinixH, I hope an official fix will come soon ;)

T0ytoy commented 1 year ago

I identified the issue, php class OCP\App is no longer available, legacy support is there : OC_App (https://github.com/nextcloud/server/blob/master/lib/private/legacy/OC_App.php)

I opened a pull request here : https://github.com/CarnetApp/CarnetNextcloud/pull/199

Maybe it can eventually be merge into the main branch, in the meantime you can take what's inside to fix your files in your own nextcloud ;)

MartinixH commented 1 year ago

@T0ytoy nice work! I identified that missing class too, but didn't find that legacy support or any other easy fix. Hope that will be merged soon :-)

hackitz commented 1 year ago

thank you worked like a charm, hopefully an update comes along.

hackitz commented 1 year ago

looks like PhieF, just updated app info.xml so looks like a fix is coming, thank you so much.

PhieF commented 1 year ago

in comiiiiing

PhieF commented 1 year ago

released