search

Carpe-Hora / SmsSender

[DEPRECATED] The almost missing SMS sending PHP library.
MIT License
54 stars 19 forks source link

Add indian provider Valuefirst #12

Closed kbsali closed 10 years ago

kbsali commented 10 years ago

implements : send(), getStatus() and getCredit()

K-Phoen commented 10 years ago

Looks like this PR is a bit messy. Could you clean it up a bit and submit it again please? As it's an addition of a new provider, the PR should have only one commit containing the provider and the unit tests.

kbsali commented 10 years ago

well, as I mentioned in my other PR, there seems to be with the merging of the 1st PR and for some reasons some of the commits of the 1st PR appear here too... I tried squashing commits locally, but no luck so far.

kbsali commented 10 years ago

ok, squashed all the valuefirst related commits into 2. but i guess now that there is a new "value-first" branch, this PR will not be merged, right?

I just "need" this provider integrated now! :)

K-Phoen commented 10 years ago

Yep, you're right : I started to clean your PR in the value-first branch but I still have work to do (with your code but also with how the errors are handled in providers).

I plan to work on this tonight, but being in Montréal right now it probably means tomorrow for you ;)

kbsali commented 10 years ago

:+1: