Carpe-Hora / SmsSender

[DEPRECATED] The almost missing SMS sending PHP library.
MIT License
54 stars 19 forks source link

Remove urlencode from getMessage #18

Closed calinrada closed 10 years ago

calinrada commented 10 years ago

Removed urlencode from getMessage for DC 0 and 1 because we receive messages like Your+name+is+Smith

K-Phoen commented 10 years ago

Makes sense.

But I'd like to have @kbsali input to know why there was a call to urlencode.

calinrada commented 10 years ago

Most likely it was a copy + paste mistake. I have adapted the initial class for internal use, because the guys from CBF have only php4 example. In any case, in their example and also in the class that i have and it is working, we do not have urlencode method applied.

    public function setMSG ($msg)
    {
        $this->message = $msg;
        return true;
    }
kbsali commented 10 years ago

to be honest i cannot remember now, but @calinrada is probably right.

K-Phoen commented 10 years ago

Alright then!

K-Phoen commented 10 years ago

Thanks @calinrada!