search

Carpe-Hora / SmsSender

[DEPRECATED] The almost missing SMS sending PHP library.
MIT License
54 stars 19 forks source link

We should provide a unified representation for SMS status #5

Closed K-Phoen closed 12 years ago

K-Phoen commented 12 years ago

Each provider gives us this information using its own method. For this reason, we should have a way to abstract this information from the used provider. This could be done by simply using predefined constants for the most common statuses :

willdurand commented 12 years ago

Sure, put these 5 constants in your result interface. It's more than enough, and will be fine :)

I don't know when a SMS will be "submitted" as the "submit" process is done by the sender, which doesn't deal with SMS objects until to create a response…

Also, what is an expired SMS ?

K-Phoen commented 12 years ago

I just picked these constants in the Esendex API documentation. According to it, a SMS can have a submitted status when a message is successfully submitted to their delivery system, but not sent yet. An expired SMS is a sent message, but which could not be delivered during its validity period.

willdurand commented 12 years ago

Doesn't make sense at the lib level..

Envoyé de mon iPhone

Le 7 janv. 2012 à 17:36, Kévin Gomezreply@reply.github.com a écrit :

I just picked these constants in the Esendex API documentation. According to it, a SMS can have a submitted status when a message is successfully submitted to their delivery system, but not sent yet. An expired SMS is a sent message, but which could not be delivered during its validity period.

Reply to this email directly or view it on GitHub: https://github.com/Carpe-Hora/chSmsSender/issues/5#issuecomment-3396614

K-Phoen commented 12 years ago

I added the "sent", "delivered" and "failed" statuses. For now, I just need this ones, so I'll stick with only these three.