search

CarpeNoctem / Sensor-Watch

A board replacement for the classic Casio F-91W wristwatch
Other
1 stars 0 forks source link

Simple Tide - Bigfix - Broken Tide Recalculation #15

Closed CarpeNoctem closed 1 week ago

CarpeNoctem commented 1 week ago

Tide recalculation function seems to have been broken by commit 4472bff. It was very late, and I had a feeling that big refactor would break something...

CarpeNoctem commented 1 week ago

Just had a quick look at the code and ran a test in the emulator, and this doesn't actually appear to be broken. I'm not sure why the recalculation didn't seem to trigger on my watch... Maybe I was in the middle of testing the user/system date change thing? I've re-set the tides now on the watch now, and will be able to see shortly whether they get updated.

CarpeNoctem commented 1 week ago

Update: It seems that the first tide update works, but then stops working after that. So this may have been an existing bug. Looking into why it only works now.

CarpeNoctem commented 1 week ago

Okay, found the bug. It was indeed an existing bug; not mine, but rather here in the main firmware: https://github.com/joeycastillo/Sensor-Watch/commit/76b580a5be70df3e06dadb42fe328d66e1f83d31

I'll have to do some fast-forwarding.

CarpeNoctem commented 1 week ago

This is now fixed by pulling in upstream changes that include that leap-year bug fix. Commit: be06004a8bb0ab5fac36c7c0df5aa9c0cb9e5c05