Open jon-tow opened 1 year ago
Assignee: @glerzing will be taking a go at this :)
I'm curious as to the status of this issue/PR
I'm developing automated tests for it, there should be a PR soon.
@glerzing look forward it
@glerzing when will have a pr?
It should be ready for PR tomorrow, sorry for the wait.
🚀 The feature, motivation, and pitch
Let's migrate to
peft
.Tasks
Doing so will require the following updates:
Replace the
opendelta
setup in theAccelerateBaseTrainer
with apeft
backed setup: https://github.com/CarperAI/trlx/blob/92b68e4d8c5d59e6ba25d12fd9acfe10287be689/trlx/trainer/accelerate_base_trainer.py#L145-L155Handle fine-grained layer capturing to only modify the upper trunk layers of hydra architectures as handled below: https://github.com/CarperAI/trlx/blob/92b68e4d8c5d59e6ba25d12fd9acfe10287be689/trlx/utils/modeling.py#L414-L428
Motivation
Citing @ethankim00's concerns with
opendelta
:opendelta
import fails due to an unnecessaryturtle
package import. Even if pip installed, users may be required to havesudo
privileges to install the corresponding base graphics package https://github.com/thunlp/OpenDelta/issues/47peft
library, which has been growing rapidlyopendelta
Alternatives
No response
Additional context
No response