Carr1005 / lighthouse-batch-parallel

A module for helping collecting websites' Lighthouse audit data in batches. Get the report data stream in CSV, JS Object or JSON format. Also provide a cli-tool to generate the report file in CSV or JSON format directly.
Apache License 2.0
28 stars 10 forks source link

Cumulative Layout Shift not available? #15

Closed cappe closed 3 years ago

cappe commented 3 years ago

Hello,

It seems that there's no Cumulative Layout Shift metric available. The documentation states that customAudits can be used to enable more metrics. However, the link where the documentation points to (https://github.com/GoogleChrome/lighthouse/blob/d8410d5f81db8b3f98304f338afb7309719be0ae/lighthouse-core/config/default-config.js#L365), I cannot find a metric for Cumulative Layout Shift.

Am I missing something or is it just not implemented?

Carr1005 commented 3 years ago

Hi there!

I found out the Lighthouse version of this module is too old to audit Cumulative Layout Shift. Also, the link you mentioned is also outdated, this is the correct source, thanks for pointing it out.

I've tested it, if you are in a rush, clone the project and update the version of the Lighthouse by yarn can directly make your goal. I'll publish the fix asap, really appreciate your feedback. 🙌

cappe commented 3 years ago

@Carr1005 Thank you so much. I honestly thought I'm an idiot who just can't read the documentation haha. Really appreciate your work. Feel free to close this issue when the fix is in :)

Carr1005 commented 3 years ago

Solved by #16