Carrooi / Node-FsMock

[ABANDONED] Mock for fs module
MIT License
7 stars 2 forks source link

writing data when given raw data buffer #8

Closed sdumetz closed 9 years ago

sdumetz commented 10 years ago

The buffer is handled as it should afterward. Code was just lacking an if statement to handle it.

I have not tested it fully yet. It works in my use case as explained in issue #7 but I can't guarantee it's failsafe.

davidkudera commented 10 years ago

Thank you.

Wouldn't it be too much problem to add tests cases here please?

Second tests file is same like the first one, it just contains Windows paths and windows: true option.

You can for example create data directory in test directory with some testing file and use code from your example https://github.com/sakren/node-fs-mock/issues/7#issuecomment-41011990.

If you will add it, can you also please squash all commits together?

sdumetz commented 10 years ago

Good idea, I kept it separated to test and forgot to group the two.

I'll try to create test cases for it asap and amend my commit.

davidkudera commented 9 years ago

Hello, I just wanted to ask, if you'll be able to finish that PR

davidkudera commented 9 years ago

https://github.com/sakren/node-fs-mock/commit/32e93a7f227fb310a09c5b4b2a08a5622fdc8822