search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.1k stars 175 forks source link

Add optional DependencyContextAssemblyCatalog in AddCarter #136

Closed tomzo closed 5 years ago

tomzo commented 5 years ago

TL;DR assembly scanning does not work in all cases as one might expect. E.g. entry assembly is not the one with carter modules when running tests with

dotnet restore
dotnet publish -c Release
dotnet packages/build/xunit.runner.console/tools/netcoreapp2.0/xunit.console.dll tests/MyTests/bin/Release/netcoreapp2.1/publish/MyTests.dll

No carter modules would be found then and it returns 404 on everything.

  1. This is not breaking the API or current behavior in any way.
  2. Otherwise a patch in AddCarter is needed in practically all projects which run tests with carter modules.

In practice same as #88 but rebased on current master.

I know there is work going on adding bootstrapper #122 but that seems won't be merged any time soon. This is a small patch for now.

jchannon commented 5 years ago

Thanks!

Did you see the comment in the earlier issue where we tried to handle this? https://github.com/CarterCommunity/Carter/pull/88#issuecomment-371507993

tomzo commented 5 years ago

Hi,

Sorry I don't get how that sample is helping, or if you want me to show you my project structure. But here is a solution with 2 projects including tests and basically running ./build.sh would fail tests with 404 if AddCarter is not patched https://github.com/tomzo/spike-carter-autofac/tree/carter-136

You would have to revert https://github.com/tomzo/spike-carter-autofac/commit/294f8cf3ccc7350bc278e9b6008aafbb1537c86b to get the error.

tomzo commented 5 years ago

@jchannon can you either merge or close this? I'd like to know if I should start releasing internally my patched version of Carter package or I can expect this to be upstream some time soon.

jchannon commented 5 years ago

Thanks 👍