search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.1k stars 175 forks source link

Fix naming convetions for AsJson and FromStream #154

Closed danielmoncada closed 5 years ago

danielmoncada commented 5 years ago

Update to fix Async naming in Response extensions. (append Async for methods that return a Task)

JoeStead commented 5 years ago

Hi Daniel,

Thanks for the PR, the effort is appreciated!

The decision not to suffix these methods with Async was a conscious one in the early days (when it was still known at Botwin). As there are no sync overloads for these methods, it creates unnecessary noise. I know this is a hotly debated opinion, but it is the one Carter took.

Thanks again for the effort, and feel free to contribute in the future, it is appreciated

danielmoncada commented 5 years ago

@JoeStead thanks Joe, that makes sense.