search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.08k stars 175 forks source link

Please don't make CarterDiagnostics internal #173

Closed gkinsman closed 5 years ago

gkinsman commented 5 years ago

Currently the only way to customise registrations of CarterModule is to not use AddCarter, and register everything yourself, which isn't a big deal. This isn't possible though, if something can't be registered because it's internal, like CarterDiagnostics.

Given it's resolvable from the container and hence accessible by users, it's really considered part of the public API - do you think it's reasonable to keep it public?

Cheers

jchannon commented 5 years ago

I actually think that part of #172 we've created a mirror copy of it and might need to look to make them one class now

jchannon commented 5 years ago

Fixed as part of #172 - CarterDiagnostics was removed