search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.08k stars 175 forks source link

Check first if property type is Guid and if so then handle it separat… #195

Closed abazanov closed 5 years ago

abazanov commented 5 years ago

Fix for Issue #194

jchannon commented 5 years ago

Looks good, only thing I'm unsure of is the sln changes. I'll pull it down later to see if I can open it still :)

abazanov commented 5 years ago

I would ignore the sln changes and pull in only the code changes. Are you able to cherry-pick?

jchannon commented 5 years ago

Afraid not

abazanov commented 5 years ago

Shall I delete it from the PR?

jchannon commented 5 years ago

yes please

jchannon commented 5 years ago

this looks like you've deleted the sln file.

you'll need to checkout the sln file from the master branch so there are no differences between what you want to commit to master from your copy

git checkout master -- Carter.sln

abazanov commented 5 years ago

Its my first ever PR in GitHub so I am trying to find my way round it. Where do I run that command please?

jchannon commented 5 years ago

No worries.

You would run that in a terminal on your machine

abazanov commented 5 years ago

Let me do it again, because its gone very wrong.