CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.06k stars 174 forks source link

Possibility to choose json.net over system.text.json #227

Closed wastaz closed 4 years ago

wastaz commented 4 years ago

The new system.text.json is faster, but it is quite lacking in what it can actually do. I have several models which requires features that system.text.json does not support and I would really like to be able to plug in json.net again :)

JoeStead commented 4 years ago

It's happening: https://github.com/CarterCommunity/Carter/pull/225

bugproof commented 3 years ago

One bad thing about this is that it forces dependency upon Newtonsoft.Json. It would be better if it was split to a separate NuGet like Carter.Serialization.NewtonsoftJson or something like that

jchannon commented 3 years ago

Agree. We'll see what happens with .Net 6 and the impact that might have

bugproof commented 3 years ago

And what impact should it have? Is .Net 6 changing something in this regard?

jchannon commented 3 years ago

Not sure at this point :)

On Sat, 17 Apr 2021 at 14:19, bugproof @.***> wrote:

And what impact should it have?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/227#issuecomment-821821596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJVE4BJL7SK2N47NRCTTJGDH5ANCNFSM4JZ7O2JQ .