search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.06k stars 174 forks source link

Add option to disable OpenApi feature which is enabled by default #229

Closed olekyd closed 4 years ago

jchannon commented 4 years ago

Is it causing issues? I’m not against adding the option though. Feel free to add the property to the option class and return 404 if disabled in a PR? :)

On Mon, 23 Dec 2019 at 15:27, alifxyd notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/229?email_source=notifications&email_token=AAAZVJRAOBN42HMXIFUNH3DQ2DKGBA5CNFSM4J6VKA32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICLGVIA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJSXJXLEDTDWFROWIULQ2DKGBANCNFSM4J6VKA3Q .

olekyd commented 4 years ago

I don't want to expose the /openapi endpoint when there is no need for it. And it would be nice to have it configurable. As a workaround I can create a middleware to reject all the requests to it, but it's better to not map it on startup.

Okay, will try to find some time for this a bit later.

Thanks