search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.06k stars 174 forks source link

Accept route metadata instance #234

Closed heerup closed 2 years ago

heerup commented 4 years ago

I changed to referring an interface IRouteMetadata instead of the abstract class (the abstract base class is still there) to allow for more composition scenarios. Then I Added the option to pass an instance of IRouteMetadata instead of using the type parameter.

jchannon commented 4 years ago

Could you add an example to the sample app to show how you see having this interface put in providing value or maybe document it in the PR, whatever you think is easier for you :)

On Mon, 13 Jan 2020 at 07:11, heerup notifications@github.com wrote:

I changed to referring an interface IRouteMetadata instead of the abstract class (the abstract base class is still there) to allow for more composition scenarios. Then I Added the option to pass an instance of IRouteMetadata instead of using the type parameter.

You can view, comment on, or merge this pull request online at:

https://github.com/CarterCommunity/Carter/pull/234 Commit Summary

  • Move to using a route metadata interface.
  • Accept Routemetadata instances

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/pull/234?email_source=notifications&email_token=AAAZVJQKDF7BQKBBM7CPHPTQ5QHZ7A5CNFSM4KF5OJO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFVFVSQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJVM42EWIULKNL7CNZ3Q5QHZ7ANCNFSM4KF5OJOQ .