search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.06k stars 174 forks source link

Form Binding logic is extremely inefficient #243

Closed davidfowl closed 2 years ago

davidfowl commented 4 years ago

Bytes -> Dictionary -> Another Dictionary -> JSON string -> Object

https://github.com/CarterCommunity/Carter/blob/2dfc291a518d7d9e2febd78b203538e72ea9306e/src/Carter/Modelbinding/BindExtensions.cs#L39-L67

jchannon commented 4 years ago

I knew this when first written and never gone back to look at it unfortunately

On Sat, 14 Mar 2020 at 23:21, David Fowler notifications@github.com wrote:

Bytes -> Dictionary -> Another Dictionary -> JSON string -> Object

https://github.com/CarterCommunity/Carter/blob/2dfc291a518d7d9e2febd78b203538e72ea9306e/src/Carter/Modelbinding/BindExtensions.cs#L39-L67

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJSUDL4IRVKSJJQJJJTRHQGPJANCNFSM4LJ6S6CA .

davidfowl commented 4 years ago

It would be good to understand if people are using this feature of Carter. Especially if it’s mostly used for backend APIs maybe you can eventually kill the feature

jchannon commented 4 years ago

Yeah not entirely sure on usage numbers. Hard to calculate that. It was added as someone asked for it I think but would assume most is json bodies

On Sun, 15 Mar 2020 at 15:59, David Fowler notifications@github.com wrote:

It would be good to understand if people are using this feature of Carter. Especially if it’s mostly used for backend APIs maybe you can eventually kill the feature

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/243#issuecomment-599228885, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJW4HLCUSAON5T5BHBDRHT3PHANCNFSM4LJ6S6CA .

jchannon commented 2 years ago

Have killed the feature. Happy to take a performant implementation to add back in