Bind logging - Githubissues

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.

MIT License

2.06k stars 174 forks source link

Bind logging #244

Closed jeffdoolittle closed 4 years ago

jeffdoolittle commented 4 years ago

@jchannon is this along the lines of what you had in mind? Also, I can revert the .sln and global.json changes if you prefer. Let me know.

JoeStead commented 4 years ago

Hey Jeff, thanks for the PR, it's appreciated!

I haven't looked at it in detail right now, but I have noticed a couple of styling inconsistencies, using _myVar instead of this.myVar for example.

I know there's no style guide as such, but consistency with other code would be great!

jeffdoolittle commented 4 years ago

Fixed the naming to match, and reverted the .sln and global.json changes.

jeffdoolittle commented 4 years ago

Did a bit more clean up:

put using statements inside namespaces to match the rest of the codebase
added test coverage to validate the logging behavior for the model binding

jchannon commented 4 years ago

Awesome stuff! Thanks @jeffdoolittle 👍