search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.11k stars 174 forks source link

Add logging in OpenAPI #245

Closed jchannon closed 2 years ago

jchannon commented 4 years ago

If something fails for example https://github.com/CarterCommunity/Carter/blob/master/src/Carter/OpenApi/CarterOpenApi.cs#L30 we need to log why.

Might be worth logging other areas to highlight what's going on in the output generation

jeffdoolittle commented 4 years ago

I'll take this one also. Any other places you want logging?

jchannon commented 4 years ago

Not off the top of my head but feel free to take a look around the code base and add any you think would be helpful.

Saw your earlier tweet and glad you’re here! I’m sure there’s lots you can teach us 😄so you have nothing to worry about. Have fun!

On Sat, 21 Mar 2020 at 07:36, Jeff Doolittle notifications@github.com wrote:

I'll take this one also. Any other places you want logging?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/245#issuecomment-602008758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJTTLECZZFPU6ABPZVDRIRU6ZANCNFSM4LOOXH5Q .

jchannon commented 4 years ago

Also just realised wrong Jeff 😂😂

Point still stands though 😄

On Sat, 21 Mar 2020 at 07:39, Jonathan Channon jonathan.channon@gmail.com wrote:

Not off the top of my head but feel free to take a look around the code base and add any you think would be helpful.

Saw your earlier tweet and glad you’re here! I’m sure there’s lots you can teach us 😄so you have nothing to worry about. Have fun!

On Sat, 21 Mar 2020 at 07:36, Jeff Doolittle notifications@github.com wrote:

I'll take this one also. Any other places you want logging?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/issues/245#issuecomment-602008758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJTTLECZZFPU6ABPZVDRIRU6ZANCNFSM4LOOXH5Q .

jeffdoolittle commented 4 years ago

No worries. Assign it to me and I'll dive in over the next few days.

jchannon commented 2 years ago

Carter 6 uses ASP.NET Core OpenAPI