search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.06k stars 174 forks source link

Make API version configurable #256

Closed JoeStead closed 3 years ago

JoeStead commented 3 years ago

Fixes #255 by making the API version configurable

JoeStead commented 3 years ago

I have no clue WTF is going on with that diff tool stuff. Gonna go right ahead and say that test needs changing

jchannon commented 3 years ago

Can you add a openapi property which should be 3.0.0. The test is running a comparison of a hard coded json doc to what calling a route that will return a openapi doc

JoeStead commented 3 years ago

No, because it isn't available on the type

jchannon commented 3 years ago

Looks like it might just add it https://github.com/microsoft/OpenAPI.NET/blob/vnext/src/Microsoft.OpenApi/Models/OpenApiDocument.cs#L75

On Mon, 3 Aug 2020 at 09:28, Joe Stead notifications@github.com wrote:

No, because it isn't available on the type

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/CarterCommunity/Carter/pull/256#issuecomment-667885847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZVJVFUGD57TN3YSKPCTTR6ZYLNANCNFSM4PSPWGQQ .

jchannon commented 3 years ago

Cheers! 👍