search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.05k stars 172 forks source link

Add workflow to automate updating references to Carter NuGet package #304

Closed mderriey closed 1 year ago

mderriey commented 1 year ago

Sort of related to #298, and discussed in https://github.com/CarterCommunity/Carter/pull/299#issuecomment-1257956828

This pull request adds a new manual workflow that crawls through the .csproj files in the repo and updates references to the Carter NuGet package. The workflow uses the NuGet API to find the latest published version of the package; there's the option of including prerelease versions in the search process.

Lots of junk in the workflow file

Manual workflows can only be run if their workflow file are in the default branch, which is not the case here. As a result, I added a push trigger to test out the process. I've highlighted the portions that will be removed before this gets merged if deemed aceptable.

Edit: that's now been removed in https://github.com/CarterCommunity/Carter/pull/304/commits/3448d3323a99624b7400808bf54369367d2786b0

What about the other repositories?

You mentioned that you were interested in having such a process for several repos under the Carter organisation. This PR deliberately focuses on a single repository, and I've thought about how to use it in several repositories. If you're happy with this and it gets merged, I'll open a new issue with my thoughts and we can take it further.

Test runs

Here's a run where we include prerelease versions, and commit and push.

We can see it worked nicely, and resulted in https://github.com/CarterCommunity/Carter/commit/b3e0e7b2527857cc5a8a2134aa321780da377d33, which looks like it was authored by Jonathan; it was of course reverted in https://github.com/CarterCommunity/Carter/commit/516dd022daca745f52d383def158bb57fc5f4482.

Changes required before this can get merged

jchannon commented 1 year ago

Might be worth a chat on the Carter Slack channel about these 3 PRs to discuss what we should do going forward?

jchannon commented 1 year ago

Do we need to merge #303 and then #304?

mderriey commented 1 year ago

Might be worth a chat on the Carter Slack channel about these 3 PRs to discuss what we should do going forward?

Apologies, I missed this 🤦‍♂️ I'll join quickly and we can chat about it.

Do we need to merge #303 and then #304?

I don't think this is dependent on the other one.