search

CarterCommunity / Carter

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.
MIT License
2.05k stars 172 forks source link

Update target framework to dotnet 8 #330

Closed scardetto closed 7 months ago

scardetto commented 7 months ago

As far as I can tell there are no breaking changes to upgrade to dotnet 8. The only issue I saw was a new deprecation warning in the mock authentication test. I checked out the referenced URL for dotnet 8 and the code sample they provide is still using the same signature. All of the tests are still passing.

Also, it looks like the Carter.ResponseNegotiators.Newtonsoft project references the NuGet package and not the project, so I can't update that without your assistance. If you publish a pre-release Carter package I can update the reference and run the unit tests against the pre-release version.

Additionally, I updated the FluentValidator reference to the latest version in all projects.

Let me know if there's anything else I can do.

jchannon commented 7 months ago

Great stuff! I'll try and take a proper look at this at some point, I've just triggered the Github Action

scardetto commented 7 months ago

Got a build failure publishing the tests results. All the tests have actually passed according to the logs. I looked at other PR's and it looks like this has happened before. Let me know if there is anything I can do.

jchannon commented 7 months ago

Thanks @scardetto awesome stuff!, Will try and get a release out asap