CarterLi / iina

The modern video player for macOS with additional features and bug fixes.
https://iina.io
GNU General Public License v3.0
678 stars 29 forks source link

Chapter markings aren't visible when in full screen #16

Closed ViRo3 closed 2 years ago

ViRo3 commented 2 years ago

When the app is windowed, the chapter markings on the playback slider is visible but when in full screen the markings aren't visible

System and IINA version:

Expected behavior: The markings should be clearly distinct no matter what the background to the OSC is.

Actual behavior:

Markings of chapters disappear when in full screen is OSC fulls over black borders. The markings should be distinct no matter the background of the OSC.

Above

Refer to attached screenshots : OSC with chapters in windowed OSC with chapters in full screen

How often does this happen? Always

robert-corlett commented 2 years ago

The contrast of the chapter markers in the windowed OSC in either dark or light mode is exceptionally poor, and is not visible in the fullscreen OSD when in dark mode. I propose a change, see commit bc237b1

What do y'all think?