CarterLi / iina

The modern video player for macOS with additional features and bug fixes.
https://iina.io
GNU General Public License v3.0
678 stars 29 forks source link

make depends fails trying to copy include files #22

Closed low-batt closed 2 years ago

low-batt commented 2 years ago

System and IINA version:

Expected behavior: make depends is successful

Actual behavior:

make depends fails at cp command:

rm -rf deps/include/mpv deps/include/ffmpeg
bash -c 'cp -r "/opt/homebrew/opt/ffmpeg-iina/include/"* deps/include/'
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory
make: *** [depends] Error 64

Steps to reproduce: Run "make depends"

How often does this happen? Everytime

CarterLi commented 2 years ago

Yes I'm confused by this strange CI issue

cp -r "/opt/homebrew/opt/ffmpeg-iina/include/"* deps/include/ doesn't seem to be problematic, and works well on my mac

CarterLi commented 2 years ago

I'm testing CI with some changes, hence lots of force-push

low-batt commented 2 years ago

Is that why my commit just disappeared? I had just pushed a fix for iina#3211. I thought it made it in as I remember seeing 100 commits ahead of IINA, but now back to 99. I'll hold off until you give the ok that you have CI working and it is safe to push.

low-batt commented 2 years ago

Do you have some special upgraded cp on your Mac? Normally you use captial -R for recursive with cp.

low-batt commented 2 years ago

The other build issues I had with make depends seemed to have to do with having already built mpv before. brew wanted reinstall to be used instead of install. Oh, and I'm missing the "create-dmg" app.

CarterLi commented 2 years ago

Do you have some special upgraded cp on your Mac? Normally you use captial -R for recursive with cp.

What the...

I use gnu-coreutils and never know that

low-batt commented 2 years ago

Ah. I see cp -r is a gnu-coreutils thing. Also "shell" wasn't recognized for me.

CarterLi commented 2 years ago

However cp -r used to work well

I think I know what the real problem is

CarterLi commented 2 years ago

CI is fine now. Closing