CarterLi / iina

The modern video player for macOS with additional features and bug fixes.
https://iina.io
GNU General Public License v3.0
681 stars 29 forks source link

HDR display doesn't look right #30

Closed MikeWang000000 closed 2 years ago

MikeWang000000 commented 2 years ago

System and IINA version:

Expected behavior:

QuickTime

Actual behavior:

IINA-HDR


Steps to reproduce: Play the file below. [Attachment]

How often does this happen? Every time

CarterLi commented 2 years ago

Sorry for slow respond. I'm currently in holiday and I will test it next week.

However, let's move HDR display related issue to https://github.com/iina-plus/iina/issues/8 for easier bug tracking

CarterLi commented 2 years ago

Works for me

WechatIMG23

Please don't use screenshot to capture the image because screenshot always works on SDR mode, luminance on the result image above SDR range will be clipped.

MikeWang000000 commented 2 years ago

I am using Macbook Air 2020 (M1). Its built-in display supports HDR according to the official website. It has a smaller maximum nits than the pro, though. IINA's HDR configuration makes the video overexposed :(

https://user-images.githubusercontent.com/11748152/153814165-92195f4b-4b1e-4232-8cd5-ddc5b1353f9f.mov

MikeWang000000 commented 2 years ago

After using --tone-mapping, the overexposure problem is solved. Probably the same reason as #8.

I'm not very familiar with HDR, sorry for the duplicate issue.

CarterLi commented 2 years ago

It has a smaller maximum nits than the pro, though

What number is that?

MikeWang000000 commented 2 years ago

Mac models that support HDR 🔗

These Mac models support HDR video on their built-in display (if applicable) and external HDR10-compatible displays.

Model Nits (brightness)
MacBook Pro (14-inch, 2021) 1000 (1600 peak)
MacBook Pro (16-inch, 2021) 1000 (1600 peak)
MacBook Pro (13-inch, M1, 2020) 500
MacBook Pro (13-inch, 2020, Two Thunderbolt 3 ports) 500
MacBook Pro (13-inch, 2020, Four Thunderbolt 3 ports) 500
MacBook Pro (16-inch, 2019) 500
MacBook Pro (13-inch, 2019, Two Thunderbolt 3 ports) 500
MacBook Pro (15-inch, 2019) 500
MacBook Pro (13-inch, 2019, Four Thunderbolt 3 ports) 500
MacBook Pro (15-inch, 2018) 500
MacBook Pro (13-inch, 2018, Four Thunderbolt 3 ports) 500
Model Nits (brightness)
MacBook Air (M1, 2020) 400
MacBook Air (Retina, 13-inch, 2020) 400
MacBook Air (Retina, 13-inch, 2019) 400
MacBook Air (Retina, 13-inch, 2018) 400
Model Nits (brightness)
iMac (24-inch, M1, 2021) 500
iMac (Retina 5K, 27-inch, 2020) 500
Model Nits (brightness)
iMac Pro 500