HDR does not work when using HTTP streaming

CarterLi / iina

The modern video player for macOS with additional features and bug fixes.

https://iina.io

GNU General Public License v3.0

679 stars 29 forks source link

Closed ArpitKubadia closed 2 years ago

ArpitKubadia commented 2 years ago

The image on top is when doing HTTP streaming and the one below is when I downloaded that file locally and played it.

HDR is disabled when streaming content with the button to enable/disable it greyed out

Not sure if this is a bug or a pending feature. Is this fixed in any future release? I am currently on v1.2.0-32

Thank you!

hoangtiin commented 2 years ago

Worked on my side. But I have to increase the brightness for a better display.

Disabled HDR

Enabled HDR

HDR with higher brightness.

CarterLi commented 2 years ago

Works for me

Please provide detailed reproduce steps for further discussion

ReeganExE commented 2 years ago

Works for me

Please provide detailed reproduce steps for further discussion

Seems like it's an issue.

For playing HTTP url, the Primaries says it's HDR, but Colorspace doesn't. (then the HDR switch is disabled).

But playing it at local, I get HDR as expected.

@CarterLi any idea?

ReeganExE commented 2 years ago

Looks like the root cause is from here https://github.com/iina/iina/issues/3806#issuecomment-1154518956. I just tried the latest IINA+ build (which included this commit ce0de9cd5) on several HDR videos and it worked as expected.

Thanks.