search

CarterLi / iina

The modern video player for macOS with additional features and bug fixes.
https://iina.io
GNU General Public License v3.0
678 stars 29 forks source link

Can't turn on HDR when resuming video #50

Closed liu731 closed 2 years ago

liu731 commented 2 years ago

System and IINA version:

Expected behavior: HDR can be turned on when resuming video

Actual behavior: Can't turn on HDR when resuming video

Steps to reproduce:

  1. Open the HDR video for the first time, it is normal at this time
  2. Exit IINA
  3. Resume the video of step 1, and HDR cannot be turned on at this time (the button is gray)

Interestingly if you want to solve the above problem

  1. Clear the playback record and open it again

How often does this happen? Always

CarterLi commented 2 years ago

Can someone else reproduce this issue?

M-Makise-Kurisu commented 2 years ago

I can reproduce this issue. But for me I don't need clear the record, completely quit IINA will bring HDR back, for once. macOS 12.3.1(M1 Max) IINA 1.2.0 129

CarterLi commented 2 years ago

So what's the issue for you @M-Makise-Kurisu

M-Makise-Kurisu commented 2 years ago

So what's the issue for you @M-Makise-Kurisu

Resume also disable HDR for me

CarterLi commented 2 years ago

Please record a movie like what I do

https://user-images.githubusercontent.com/6134068/167397990-e663d1a7-c575-4a65-b685-14cb6cf8623a.mp4

liu731 commented 2 years ago

https://user-images.githubusercontent.com/49366127/167402494-62b84927-b723-457e-8d95-3aadd048e477.mov

CarterLi commented 2 years ago

I can't reproduce your issue with the same steps.

M-Makise-Kurisu commented 2 years ago

Mine is exactly the same with @liu731

space192 commented 2 years ago

a quick fix for me is to get the slider at the beginning of the video before closing it, when I resume the HDR option re appears again. or if you forgot to bring it back to the beginning when you reopen the video just bring the slider to beginning then close the video and open it again !

liu731 commented 2 years ago

This method works for me. Compared to other videos, HDR videos seem to require more loading/parsing? time, and iina-plus seems to only do this on the first play or at 0:00 timeline. @space192

CarterLi commented 2 years ago

This method works for me. Compared to other videos, HDR videos seem to require more loading/parsing? time, and iina-plus seems to only do this on the first play or at 0:00 timeline. @space192

No. I won't bother detecting if it's at 0:00

Because HDR feature has been merged into the official IINA repo, please report theses issues to them to get more duscussions.