Expected behavior:
Building using make completes successfully.
Actual behavior:
Build fails with a compilation error in MPVController. And yet the GitHub builds are working. I'm confused as to why it is failing for me. This is what I'm seeing...
/**
* This should not be used. It is deprecated and will be removed or ignored
* when the opengl_cb API is removed.
*/
const char *extra_exts;
In mpv master mpv_opengl_init_params has been updated, removing this deprecated property.
The IINA method MPVController.mpvInitRendering has been updated to not pass extra_exts when calling mpv_opengl_init_params:
var openGLInitParams = mpv_opengl_init_params(get_proc_address: mpvGetOpenGLFunc,
get_proc_address_ctx: nil)
For me this results in a compilation error when I run make as the build pulls in the version of render_gl.h that still contains extra_exts.
Checking mpv-iina.rb, IINA+ still seems to be using mpv 0.34.1? And yet MPVController has been updated to work with mpv master? I'm confused! What am I doing wrong?
Steps to reproduce:
For me all I have to do is run make.
System and IINA version:
Expected behavior: Building using
make
completes successfully.Actual behavior: Build fails with a compilation error in
MPVController
. And yet the GitHub builds are working. I'm confused as to why it is failing for me. This is what I'm seeing...In mpv 0.34.0 mpv_opengl_init_params in
render_gl.h
contains the propertyextra_exts
:In mpv master mpv_opengl_init_params has been updated, removing this deprecated property.
The IINA method
MPVController.mpvInitRendering
has been updated to not passextra_exts
when callingmpv_opengl_init_params
:For me this results in a compilation error when I run
make
as the build pulls in the version ofrender_gl.h
that still containsextra_exts
.Checking mpv-iina.rb, IINA+ still seems to be using mpv 0.34.1? And yet
MPVController
has been updated to work with mpv master? I'm confused! What am I doing wrong?Steps to reproduce: For me all I have to do is run
make
.How often does this happen? Everytime.