CarterLi / iina

The modern video player for macOS with additional features and bug fixes.
https://iina.io
GNU General Public License v3.0
678 stars 29 forks source link

Compilation failure in MPVController #62

Closed low-batt closed 2 years ago

low-batt commented 2 years ago

System and IINA version:

Expected behavior: Building using make completes successfully.

Actual behavior: Build fails with a compilation error in MPVController. And yet the GitHub builds are working. I'm confused as to why it is failing for me. This is what I'm seeing...

In mpv 0.34.0 mpv_opengl_init_params in render_gl.h contains the property extra_exts:

    /**
     * This should not be used. It is deprecated and will be removed or ignored
     * when the opengl_cb API is removed.
     */
    const char *extra_exts;

In mpv master mpv_opengl_init_params has been updated, removing this deprecated property.

The IINA method MPVController.mpvInitRendering has been updated to not pass extra_exts when calling mpv_opengl_init_params:

    var openGLInitParams = mpv_opengl_init_params(get_proc_address: mpvGetOpenGLFunc,
                                                  get_proc_address_ctx: nil)

For me this results in a compilation error when I run make as the build pulls in the version of render_gl.h that still contains extra_exts.

Checking mpv-iina.rb, IINA+ still seems to be using mpv 0.34.1? And yet MPVController has been updated to work with mpv master? I'm confused! What am I doing wrong?

Steps to reproduce: For me all I have to do is run make.

How often does this happen? Everytime.

CarterLi commented 2 years ago

I have upgraded mpv-iina ( for iina+ ) to git head to fix this issue: https://github.com/iina-plus/iina/issues/53

I forgot to update the Makefile