Carthage / Commandant

Type-safe command line argument handling
MIT License
422 stars 48 forks source link

Swift 4.1: Utilize synthesized Equatable impl #126

Closed ikesyo closed 6 years ago

mdiep commented 6 years ago

Are we ready to require this?

If we use it for Carthage, then Carthage will only build on Xcode 9.3 and thus only build on macOS 10.13. 😕

ikesyo commented 6 years ago

Good point, so should we still support Xcode 9.2/Swift 4.0 for several months, maybe until Swift 4.2?

mdiep commented 6 years ago

Probably—or even until 10.14 is out. 😞

ikesyo commented 6 years ago

Let’s make it conditional to ship this quickly.

mdiep commented 6 years ago

Unfortunately, there's a CI failure. 😞

ikesyo commented 6 years ago

Yes, that should be addressed by #127.

mdiep commented 6 years ago

Sorry. Hadn't made it to that PR yet. 😅