search

Cartmanishere / zippyshare-scraper

A module to get direct downloadable links from zippyshare download page.
MIT License
106 stars 28 forks source link

Not working - would love a fix. Thanks! #37

Open name01019 opened 2 years ago

name01019 commented 2 years ago

@Cartmanishere Thank you for this amazing script. It seems to not be working currently

[*] Using JSEngine for generating links

PyJs_anonymous1

PyJs_anonymous3 Traceback (most recent call last): File "zippyshare.py", line 144, in links, fails = zippy.parse_links(urls) File "zippyshare.py", line 68, in parse_links extract, link = f.result() File "/usr/lib/python3.7/concurrent/futures/_base.py", line 425, in result return self.get_result() File "/usr/lib/python3.7/concurrent/futures/_base.py", line 384, in get_result raise self._exception File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run result = self.fn(*self.args, **self.kwargs) File "zippyshare.py", line 33, in get_download_link extract, link = self.engine.get_download_link(link) File "/media/zippyshare-scraper-master/engines/js.py", line 88, in get_download_link self.run_js(code) File "/media/zippyshare-scraper-master/engines/js.py", line 59, in run_js self.context.execute(code) File "/home/.local/lib/python3.7/site-packages/js2py/evaljs.py", line 199, in execute exec (compiled, self._context) File "", line 23, in File "/home/.local/lib/python3.7/site-packages/js2py/base.py", line 995, in callprop cand.typeof(), repr(prop), repr(self.Class))) js2py.internals.simplex.JsException: TypeError: 'undefined' is not a function (tried calling property 'getAttribute' of 'Object')

name01019 commented 2 years ago

@Cartmanishere

Bump

Cartmanishere commented 2 years ago

Will take a look.

On Fri, Jul 29, 2022 at 18:21 name01019 @.***> wrote:

@Cartmanishere https://github.com/Cartmanishere

Bump

— Reply to this email directly, view it on GitHub https://github.com/Cartmanishere/zippyshare-scraper/issues/37#issuecomment-1199060529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFR3P3XLWDZIYUCAZQ6FSB3VWOPAFANCNFSM54NPH4RA . You are receiving this because you were mentioned.Message ID: @.***>

redx113 commented 2 years ago

D:\zippyshare-scraper-master>python zippyshare.py --in-file input_links.txt --out-file outlinks.txt [] Using JSEngine for generating links Traceback (most recent call last): File "D:\zippyshare-scraper-master\zippyshare.py", line 144, in links, fails = zippy.parse_links(urls) File "D:\zippyshare-scraper-master\zippyshare.py", line 68, in parse_links extract, link = f.result() File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 439, in result return self.get_result() File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 391, in get_result raise self._exception File "C:\Program Files\Python310\lib\concurrent\futures\thread.py", line 58, in run result = self.fn(self.args, **self.kwargs) File "D:\zippyshare-scraper-master\zippyshare.py", line 33, in get_download_link extract, link = self.engine.get_download_link(link) File "D:\zippyshare-scraper-master\engines\js.py", line 88, in get_download_link self.run_js(code) File "D:\zippyshare-scraper-master\engines\js.py", line 59, in run_js self.context.execute(code) File "C:\Users\Admin\AppData\Roaming\Python\Python310\site-packages\js2py\evaljs.py", line 199, in execute exec (compiled, self._context) File "", line 23, in File "C:\Users\Admin\AppData\Roaming\Python\Python310\site-packages\js2py\base.py", line 993, in callprop raise MakeError('TypeError', js2py.internals.simplex.JsException: TypeError: 'undefined' is not a function (tried calling property 'getAttribute' of 'Object')

I have gotten the same error as of yesterday on both .dlc and from txt with links. This used to work great. I hope both of our details can help you fix it

Cartmanishere commented 2 years ago

JFYI:

While I'm working on a fix, you can try with the text engine.

E.g.

python ./zippyshare.py --engine text

This seems to be working for me.

redx113 commented 2 years ago

The python ./zippyshare.py --engine text

I pasted 242 links, it got up to 16 of the links than errored out with list index out of range. I am guess it must be limited to 16 links at a time, so as a workaround itll work, but definitely not as useful as the normal js engine. At least while you are working on the fix though, we have a slower 16 at a time workaround. Thanks for the alt info for now

Traceback (most recent call last): File "D:\zippyshare-scraper-master\zippyshare.py", line 144, in links, fails = zippy.parse_links(urls) File "D:\zippyshare-scraper-master\zippyshare.py", line 68, in parse_links extract, link = f.result() File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 439, in result return self.get_result() File "C:\Program Files\Python310\lib\concurrent\futures_base.py", line 391, in get_result raise self._exception File "C:\Program Files\Python310\lib\concurrent\futures\thread.py", line 58, in run result = self.fn(*self.args, *self.kwargs) File "D:\zippyshare-scraper-master\zippyshare.py", line 33, in get_download_link extract, link = self.engine.get_download_link(link) File "D:\zippyshare-scraper-master\engines\text.py", line 40, in get_download_link extract = self.parser(soup) File "D:\zippyshare-scraper-master\engines\patterns\function.py", line 106, in pattern_3 d = int(soup.select('span[id="omg"]')[0].get('class')[0]) 2 IndexError: list index out of range

name01019 commented 2 years ago

Now this method doesn't work either

python ./zippyshare.py --engine text

[] All patterns have failed [] All patterns have failed [*] All patterns have failed

Cartmanishere commented 2 years ago

Ok, I'll check it out.

On Sat, Aug 20, 2022 at 9:57 name01019 @.***> wrote:

Now this method doesn't work either

python ./zippyshare.py --engine text

[ ] All patterns have failed [] All patterns have failed [*] All patterns have failed

— Reply to this email directly, view it on GitHub https://github.com/Cartmanishere/zippyshare-scraper/issues/37#issuecomment-1221193682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFR3P3S3L5KQNBKE4NMUOR3V2AUN3ANCNFSM54NPH4RA . You are receiving this because you were mentioned.Message ID: @.***>

name01019 commented 2 years ago

Ok, I'll check it out. … On Sat, Aug 20, 2022 at 9:57 name01019 @.> wrote: Now this method doesn't work either python ./zippyshare.py --engine text [ ] All patterns have failed [] All patterns have failed [] All patterns have failed — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFR3P3S3L5KQNBKE4NMUOR3V2AUN3ANCNFSM54NPH4RA . You are receiving this because you were mentioned.Message ID: **@.***>

Oh actually, I just tried python3 zippyshare.py --dlc and it works now (even though it wasn't working a few weeks ago)

So it looks like dlc works now but engine text stopped working for some reason

ztgasdf commented 2 years ago

Still not working here. JSEngine is completely kaput and TextEngine works for a few links and then dies out with a list index out of range error.

Cartmanishere commented 2 years ago

Yeah, I am aware. They changed the site in a way that broke the JS Script logic. I still haven't found a workaround for it.

Unfortunately, the pattern-matching approach is the only option for now. i.e TextEngine.

I might be able to make it a bit more resilient. But don't get time to work on this these days 😞