Test does not run without modifying the redis_utils.js

CartoDB / CartoDB-SQL-API

CartoDB SQL API

BSD 3-Clause "New" or "Revised" License

62 stars 63 forks source link

Test does not run without modifying the redis_utils.js #364

Open drzhouq opened 7 years ago

drzhouq commented 7 years ago

tried to run npm test or make check and got error : Cannot read property 'redis_host' of undefined

added "require("../helper");" to the redis_utils solved the problem.

Please check whether this is the case.

rochoa commented 7 years ago

Hi @drzhouq,

Is it happening yet? Your fix makes sense, it was probably happening due suite execution order, where a suite was not including the helper to setup the environment accordingly.

drzhouq commented 7 years ago

Hi @rochoa, I didn't create a pull request (blame my laziness or not exactly sure how the execution order). I will let you handle this. :-)

-John