Simplify throttling logic

CartoDB / CartoDB-SQL-API

CartoDB SQL API

BSD 3-Clause "New" or "Revised" License

63 stars 63 forks source link

Simplify throttling logic #634

Closed jgoizueta closed 4 years ago

jgoizueta commented 4 years ago

This introduces a couple of changes in the parameter interpretation:

copy_from_minimum_input_speed is now the total number of bytes in the interval (so we could multiply the currently configured values by the interval to preserve min. intended throughput.
the minimum speed is now inclusive (only smaller values will cause an exception).

@Algunenano will this satisfy you? 😛 @dgaubert do you think this looks safe enough?

Algunenano commented 4 years ago

@Algunenano will this satisfy you? stuck_out_tongue

LGTM but it's confusing, it's saying this.minimunBytesPerSecondThreshold but the threshold isn't per second, but per this.sampleLength.

dgaubert commented 4 years ago

Resolve conflict before proceeding, please move on. We are refactoring/optimizing a 10 lines algorithm but we still don't know if we solve the issue or not.

Algunenano commented 4 years ago

Can you add a line in NEWS about this change, please?