search

CartoDB / CartoDB-basemaps

CartoDB basemaps
http://cartodb.com/basemaps
Other
55 stars 13 forks source link

Incorrect island name in positron #53

Open nickdos opened 8 years ago

nickdos commented 8 years ago

The following tile has Lord Howe Island incorrectly labelled as Norfolk Island.

http://a.basemaps.cartocdn.com/light_all/5/30/18.png

Better illustrated in this screen shot:

image

Please correct this. Note OSM correctly labels these islands.

pnorman commented 8 years ago

This isn't coming from aries-magic-list or fixed in the develop branch, so it looks like a Natural Earth issue

almccon commented 8 years ago

Confirmed it's an error in Natural Earth's ne_10m_admin_1_states_provinces_shp file. Here are the name labels in that file, rendered in QGIS:

screen shot 2016-03-02 at 2 mar 5 26 23
almccon commented 8 years ago

I won't have time to fix this right away, but if anyone else wants to upload a modified version of that shapefile, I can merge it into the Stamen fork of Natural Earth https://github.com/stamen/natural-earth-vector.

pnorman commented 8 years ago

I had a look at the upstream natural earth, but couldn't find how to contribute, and the age of unmerged PRs isn't encouraging.

almccon commented 8 years ago

@pnorman Yes, contributing to upstream is hard, because most of the files in github are actually derived products from an ESRI Geodatabase that lives on someone's machine somewhere. So I personally wouldn't know how to fix the source issues anyway.

But whenever I find errors where I can fix the resulting shapefile (by editing it in QGIS) I push fixed zipped versions to the Stamen branch, and source those for the rendering.

See https://github.com/stamen/toner-carto/blob/master/Makefile#L260-L263 and https://github.com/stamen/toner-carto/blob/master/Makefile#L295-L303 in Toner, where some of the Natural Earth is sourced from naturalearthdata.com, and some of it is sourced from github from Stamen's fork.

I think we might have done that originally for some of the CartoDB basemap layers, but looking at datasets.txt it seems that currently it's only coming from naturalearthdata.com

nickdos commented 7 years ago

Our users have reported another incorrect label, similar to the one above.

"Geographe Bay" in Western Australia, is incorrectly placed.

CartoDB has it just below Perth but its actually a few hundred km further south. See 2 screen shots:

image

geographe-bay-osm

(orange dot OSM location marker)