CartoDB / CartoDB-basemaps

CartoDB basemaps
http://cartodb.com/basemaps
Other
55 stars 13 forks source link

New dark matter basemap with lowercase #76

Closed luisbosque closed 8 years ago

makella commented 8 years ago

@luisbosque

I added my edits and followed your pattern. The reason so many files had to be modified is because in order to get good looking lower case labels for all features, we had to make adjustments throughout the entire project.

I hope this is all ok!

The files I modified/added are as follows:

Project Files

dark-matter-all-lowercase.yml

changed the path in dark-matter-all-lowercase.yml to read global_variables_dark_lowercase.mss

Styles

global_variables_dark_lowercase.mss
admin1_labels_lowercase.mss
admin1boundary_labels_lowercase.mss
continent_labels_lowercase.mss
country_city_labels_lowercase.mss
global_variables_dark_lowercase.mss
marine_labels_lowercase.mss
osm_roads_labels_lowercase.mss
park_labels_lowercase.mss
water_labels_lowercase.mss

cc: @mbforr

luisbosque commented 8 years ago

Very nice job @makella. I take over from here

luisbosque commented 8 years ago

I've created the new layer's SQLs and add them too to the main yaml defintion

makella commented 8 years ago

@luisbosque ok! if possible, let's publish!

thank you!!

cc @mbforr

luisbosque commented 8 years ago

Should we merge and close the PR?

makella commented 8 years ago

I say yes @mbforr mentioned attaching Qlik api keys? @mbforr what do you think?

mbforr commented 8 years ago

Yeah I can't remember who set that up originally but there is a table that logs mapviews in their account - its basically the XYZ url with an API key on the end

makella commented 8 years ago

@luisbosque hey!

So we need to republish for dark-matter-all-lowercase AND also, we added positron lowercase positron-all-lowercase

I am referencing the same files in for Positron Lowercase and modified global_variables to global_variables_lowercase for the Positron version.

Please let us know if this is all right and makes sense!

thank you!!

cc @mbforr

luisbosque commented 8 years ago

Ey @makella. Ok I will test it as soon as I can. You made lots of changes to the global_variables_lowercase. This will apply to both positron and dark matter. That is ok, isnt't it?

Are the changes very noticeable? I'm kind of worried that we will have tiles with old and new styles together because of the CDN cache

mbforr commented 8 years ago

these aren't for the main basemaps yet just for the customer, correct?

On Thu, Aug 25, 2016 at 3:03 AM, luisico notifications@github.com wrote:

Ey @makella https://github.com/makella. Ok I will test it as soon as I can. You made lots of changes to the global_variables_lowercase. This will apply to both positron and dark matter. That is ok, isnt't it?

Are the changes very noticeable? I'm kind of worried that we will have tiles with old and new styles together because of the CDN cache

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CartoDB/CartoDB-basemaps/pull/76#issuecomment-242298415, or mute the thread https://github.com/notifications/unsubscribe-auth/AEmtLGIcds-T2hO9Fg4P5bk5gFjcqwO-ks5qjT5MgaJpZM4JhQI_ .

Matt Forrest Client Success Manager

CARTO 201 Moore St, Brooklyn, NY, 11206 P: (917) 463-3232 x7508 C: (612) 325-8470 carto.com http://www.carto.com/

mbforr commented 8 years ago

hey @luisbosque @javisantana these seem to be running really slowly and hear the same from the client - can we do anything to help these cache?