Improve named map provider cache - Githubissues

CartoDB / Windshaft-cartodb

Windshaft tailored for CARTO

BSD 3-Clause "New" or "Revised" License

72 stars 58 forks source link

Improve named map provider cache #1122

Closed dgaubert closed 5 years ago

dgaubert commented 5 years ago

Do not cache map template CRUD errors in Named Map provider
Add maxAge param to lru-cache to be able to refresh entries when staled
Remove mechanism to reset named map's provider and leverage lru-cache as much as possible
Refactors and ES7/8 goodies
Gather metrics from Named Maps Providers Cache to understand better how it works

Note: to review this PR, better take a look to the following commits:

https://github.com/CartoDB/Windshaft-cartodb/pull/1122/commits/6229455d25da90bc010fce334ca517fdf33ee312
- https://github.com/CartoDB/Windshaft-cartodb/pull/1122/commits/788cd9d6fb105f8bc9cb3b36d03087f85a26bdb5
- https://github.com/CartoDB/Windshaft-cartodb/pull/1122/commits/c19c7237952dd729c85febf336c9df41295822cc

You can see the new metrics in staging by clicking the image:

Algunenano commented 5 years ago

I've left a few comments but it looks good to me. One metric I always like to have for a cache is % of hit vs misses, but I'm not sure if it is within the scope of this PR.