CartoDB / academy

Academy
https://carto.com/academy
48 stars 21 forks source link

Fixes for 2 404s on academy #427

Closed beloneys closed 7 years ago

beloneys commented 7 years ago

cr @namessanti

namessanti commented 7 years ago

I think the choropleth link can be changed to our new guide: https://carto.com/academy/courses/beginners-course/your-first-choropleth-map

While it's not completely complimentary probably a good idea to start pointing away from academy (even in Academy)

@arianaescobar are you responsible for merging here also?

beloneys commented 7 years ago

Hi @namessanti

I think you copied the wrong url here (still academy, the same I fixed in the code). Is there a new choropleth guide inside /learn please? Please provide any new url so I can update them on the second sheet of Learn structure, and do the redirections in the first one with your approval :)

https://docs.google.com/spreadsheets/d/1cuvpqz-ibgQdqQ6X700XL8NVUE2tGdh6GabHN9cSOto/edit#gid=1637103861

arianaescobar commented 7 years ago

@namessanti I can code review but I believe any of us can merge this kind of changes (but let's always do a code review first!)

beloneys commented 7 years ago

Is this the link? I'm updating the urls in the doc from the mail you sent few days ago during my vacation.

Thanks!

https://carto.com/learn/guides/styling/choropleth-map-for-statistical-data

namessanti commented 7 years ago

Oops, Update was lost in my emails. That's the one!

beloneys commented 7 years ago

Changed, @arianaescobar for CR

arianaescobar commented 7 years ago

retest this please

arianaescobar commented 7 years ago

@luisbosque could you shed some light on why this is failing? I took a look at the console output but couldn't understand a thing :(

luisbosque commented 7 years ago

I don't have a clear idea about the reason. I'm going to create a issue so we can investigate it

arianaescobar commented 7 years ago

Thank you :)

arianaescobar commented 7 years ago

retest this please