CartoDB / airship

A design library for building Location Intelligence applications.
https://carto.com/developers/airship/
BSD 3-Clause "New" or "Revised" License
75 stars 14 forks source link

Create intermediate colors and enable customization at element level #568

Closed ivanmalagon closed 5 years ago

ivanmalagon commented 5 years ago

This PR is aimed to solve the following:

Next steps

elenatorro commented 5 years ago

Yesterday @makella, @rjimenezda and I had a meeting were we discussed this issue. I've updated the description, adding the changes we need to finish in this PR but also a next steps section. I think theming is a huge task we should start addressing now in different issues, we'd eventually to:

elenatorro commented 5 years ago

This is ready for CR. There are three tests failing

If I create the backstop tests from my computer, the generated results work locally but not in the CI, so I guess there's something wrong in my configuration.

IagoLast commented 5 years ago

+1 to the tabs variable.

No breaking change, and nice and good looking tabs :)