Closed ivanmalagon closed 5 years ago
Yesterday @makella, @rjimenezda and I had a meeting were we discussed this issue. I've updated the description, adding the changes we need to finish in this PR but also a next steps section. I think theming is a huge task we should start addressing now in different issues, we'd eventually to:
This is ready for CR. There are three tests failing
If I create the backstop tests from my computer, the generated results work locally but not in the CI, so I guess there's something wrong in my configuration.
+1 to the tabs variable.
No breaking change, and nice and good looking tabs :)
This PR is aimed to solve the following:
/examples/themes
directory.type
variables andui
variables.background
variables to avoid usingbadge
variables for modifying background colors (we're currently doing so in the examples)hover
,focus
andactive
variables`.support-0N
variables and use semantic variables (error, warning and success)tooltip
so we can customize the background color properly.Next steps
We need to discuss how to use
primary
andsecondary
variables in theming. For instance, both in thetoolbar
and in thetable
elements are using thesecondary
value although they're main components. This is wrong because the toolbar is an element that usually has to be aligned, by default, with the main color of the application/brand. So, for theming, is kind of hacky to use the secondary variable there. We should discuss this deeply because it implies breaking changes.Add theming customization guide This guide should cover how to customize the application, what to take into consideration when creating a theme and the differences between light and dark themes. Also, which colors are recommended to be changed, for instance, when creating a histogram, in order to fit the current theme.
Provide default themes to allow users to use them. As @makella said, it'd be really useful to have default themes the user can choose easily that also fit with our basemaps.