Closed rjimenezda closed 5 years ago
1.1.0 fixed the general slowness on the tests, we're back to ~30 secs on my machine which I think is decent.
We could redo tests to not use puppeteer but I'd rather not touch too much just in case.
Never mind, now they're randomly failing possibly because of a lack of resources on Circle, so we might have to refactor a few into using the puppeteerless approach
Fix #626
This is not being too bad for now, no apparent breaking changes. Some notes:
module
of the package is changed to another path. ~- One spec (range slider) commented for now becausedraggable
is a reserved attribute, and the spec runner fails those tests. I opened a PR to stencil to fix that, it's been merged but we'll have to wait for the patch.~ 1.1.0 included this changeisDraggable
) and markeddraggable
for deprecation for the next major to keep it clean. We should somehow track this stuff so we don't forget. On the next major we should also unify a bunch of stuff like showClear / showClearbutton etc.