Histogram max value keeps changing even though the global max is still in view

CartoDB / airship

A design library for building Location Intelligence applications.

https://carto.com/developers/airship/

BSD 3-Clause "New" or "Revised" License

75 stars 13 forks source link

Histogram max value keeps changing even though the global max is still in view #653

Open andy-esch opened 4 years ago

andy-esch commented 4 years ago

What is happening? The max value in the histogram changes (going lower) even though a 'higher' max value is still in view. histogram-max-value

What should happen? In this case, the max value is 1 and the histogram should keep the x-axis on 1 the entire time because that geometry is still in view.

Steps to Reproduce I can set you up with the data/map offline.

Device/Browser/Airship-Version Version 76.0.3809.100 (Official Build) (64-bit) cartoframes version in develop as of Sept 11

Extra information Nope, let me know how I can help. Thanks!

VictorVelarde commented 4 years ago

@elenatorro Same as in https://github.com/CartoDB/airship/issues/157, feel free to ping RT for this one

VictorVelarde commented 4 years ago

Please @CartoDB/rt-managers add this to RT

rjimenezda commented 4 years ago

Almost positive this is a VL aggregations issue, but we can investigate.

makella commented 4 years ago

I'm pretty sure this is due to the global vs. viewport aggregations and the values that VL returns. @elenatorro and I had this discussion when we were working on the globalHistogram expression.

From the globalHistogram PR:

For numeric values, we're using the sample values from the metadata, as we're doing in other global expressions such as GlobalQuantiles. As we've discussed, we'll talk about it during this cycle.