Add AU 2016 to DO - Githubissues

CartoDB / bigmetadata

BSD 3-Clause "New" or "Revised" License

43 stars 11 forks source link

Add AU 2016 to DO #582

Closed antoniocarlon closed 6 years ago

antoniocarlon commented 6 years ago

Added Australia 2016 geographies and data to the ETL

Closes https://github.com/CartoDB/bigmetadata/issues/577

Notes for the acceptance:

AU 2011 and AU 2016 are pretty similar, so I have refactored the AU ETL task (although I have done a couple of tests, we may need to check that everything is wtill working for AU 2011)
The will be (for sure) some NULL value errors when executing all the data tasks for AU 2016 (I have only tested STE)

antoniocarlon commented 6 years ago

@juanignaciosl all the CR comments come from au_columns_helper.py which is just a helper script to create the .csv file for the 2016 columns, but not a true part of the ETL process (I have executed it once to generate the csv but I think that we will never execute it again).

Do you think that it's worth a refactor? I'm not saying that it's not, just asking for an unbiased opinion...

juanignaciosl commented 6 years ago

Nah, all comments were really minor. To acceptance :rocket: