Noise in the analysis logs

[jgoizueta]

We have a function logError in the LimitsContext that expects as argument an err object with message and code properties.

But, in some cases, like when checking if limits are defined in the configuration (e.g. here), we're passing a text instead. So in such cases the text message is lost in the log and we only have a very generic "msg":"analysis:limits_error" that doesn't provide any useful information.

Since many of the analysis node limits are not defined in the configuration there's a lot of those messages the logs.

We should:

• Fix the calls that pass a text, so it is not lost (e.g. context.logError({message: 'Limit for input rows is not defined'});).
• Reconsider if the messages about limits not configured are useful, remove them otherwise

[dgaubert]

cc @CartoDB/rt-managers for priorization

[ztephm]

Please prioritize this as important-level @juanrmn . Thank you.

[juanrmn]

I've opened a PR (https://github.com/CartoDB/camshaft/pull/399) about this. So far I've just fixed the calls to logError. About the usefulness of each message, I don't feel familiarized enough with the project to judge that, so all of them seem useful to me :slightly_smiling_face:. However, if you think that any of them should be deleted, please add comments to the PR and I'll do it.

[dgaubert]

Done https://github.com/CartoDB/Windshaft-cartodb/pull/1156