CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

Requests management #122

Closed simon-contreras-deel closed 5 years ago

simon-contreras-deel commented 5 years ago

(This issue should be created in the pyrestcli repo, but we are not managing it right now)

We are managing responses in different ways, catching some exception and passing others:

We have 3 different approaches (at least) to manage responses, it could be reasonable but at least, there are problems and bugs managing errors, because the idea is to manage errors using:

but sometimes we are not using it (the client should do it explicitly if you are using the Manager for example) and in some cases, we are managing other cases here like CartoRateLimitException https://github.com/CartoDB/carto-python/blob/master/carto/auth.py#L151-L152

I don't want to write the solution here, at least I am going to say we should have a unique place where:

Related issue: https://github.com/CartoDB/carto-python/issues/112