search

CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

Add geom param to DO upload methods #166

Closed simon-contreras-deel closed 4 years ago

Jesus89 commented 4 years ago

Yep, we found this running the DODataset e2e tests in CF: https://github.com/CartoDB/cartoframes/tree/develop/tests/e2e/data/do-api.

I have one question regarding PR. Since geom_column is a URL param, should it be normalized? is this done in the AuthClient?

simon-contreras-deel commented 4 years ago

I am going to merge with the tests in red. We have a problem with them that can not be solved now.