Auth and SQL clients store base_url and username, base_url doesn't expect trailing /api anymore

[dmed256]

The changes include:

• Auth extracts username from base_url, removing special logic for different cloud/on-prem versions
• Auth + SQL clients store base_url and username for other methods to use if needed
• Removed the trailing /api in base_url (Issue #45)

I added Auth tests but I couldn't get

python setup.py test

running properly, I get

[~/git/carto-python]
> py setup.py test
running test

even when setting the assert to fail

[dmed256]

Any feedback?

[danicarrion]

looks good! thanks so much. I still need some time to figure out what the problem with the tests might be

[dmed256]

cool, thanks for checking it out

[danicarrion]

adding @alrocar to the loop

[dmed256]

@danicarrion: Hi Dani, @andy-esch and I are working on cartoframes where we extract the username out of the base_url If you would like, we can cancel this pull request since we're adding this feature elsewhere

[dmed256]

Here are the lines of code for the prototype version:

https://github.com/dmed256/cartoframes/blob/master/cartoframes/proto/context.py#L26-L34

[danicarrion]

Well, I think this type of functionality actually belongs to the SDK ;-)

[dmed256]

Yay, less logic for us then :) Thank you!

[andy-esch]

:)