search

CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

1.0.0 #52

Closed alrocar closed 7 years ago

alrocar commented 7 years ago

Hey, @danicarrion @javisantana

In my opinion 1.0.0 branch is ready to be merged into master.

What do you think?

BTW, once I have to merge, how should I do it? Seems like both branches won't automatically merge...

EDIT: OK seems like there are only 3 conflicting files... not an issue.

javisantana commented 7 years ago

About the docs, are we planning to publish it in our website? (Nice to see sphinx there 😀)

Do we have CI integration?

On Thu, May 11, 2017, 09:49 Alberto Romeu notifications@github.com wrote:

Hey, @danicarrion https://github.com/danicarrion @javisantana https://github.com/javisantana

In my opinion 1.0.0 branch is ready to be merged into master.

What do you think?

BTW, once I have to merge, how should I do it? Seems like both branches won't automatically merge...

You can view, comment on, or merge this pull request online at:

https://github.com/CartoDB/carto-python/pull/52 Commit Summary

  • total rewrite with some new features
  • made some edits and tests for NoAuthClient
  • removed comments and extra code
  • Merge pull request #20 from CartoDB/r-edits
  • finished import tests
  • fixed python sdk func
  • minor corrections
  • Merge pull request #23 from CartoDB/r2
  • working on carto export
  • working within sdk
  • simplifying exportjob, revising tests
  • have a working and polished export job, going to work on export manager
  • checking that everything works
  • stopped working on exportManager and exportJob works and is cleaned up
  • this works on my machiens, will merge with remote
  • finished export, code polished, git will be up to status, going to work on named maps
  • got methods working, need to transform to sdk style and then implement manager
  • made the maps_api more like import_api
  • finsihed named maps, and the format matches import_api, just need to figure out namedMapManager
  • got manager to work pretty well
  • fixed small issues with maps_api file
  • updated file
  • fixed small edits in exportJob
  • Merge pull request #26 from CartoDB/r-export
  • fixed some pep8 stuff
  • started work on batch sql api
  • finishing up batch api functions and dealing with update
  • finished most of the commands in the batch api, need to talk to dani
  • fixed namedMapManager and altered namedMaps
  • finished namedmaps and manager and tests
  • fixed import_api formatting
  • fixed formatting
  • fixed slightly faulty test
  • trying to get namedmaps mergeable
  • cleaned up batch api, ready for review
  • Merge branch '1.0.0' into r-namedmaps
  • finished last bits of edits
  • Merge pull request #28 from CartoDB/r-batch
  • fixed test
  • pushing namedmaps when merge with everything else
  • test suuite working
  • fixed h_method
  • Merge pull request #27 from CartoDB/r-namedmaps
  • the python sdk should be fully functional
  • finished last bit
  • fixed sqlclient name
  • Merge pull request #29 from CartoDB/r-docs
  • made sdk more pythonic
  • make small edits
  • no files for testing
  • Merge pull request #30 from CartoDB/r-docs
  • massive refactoring, interim commit
  • user tests pass
  • comment user tests
  • dataset tests now pass too (still interim release!!!)
  • emptied main init.py
  • rough refactor to use pyrestcli
  • moving everything to the project root
  • test folder renamed, tests out of setup.py
  • everything migrated to pyrestcli except maps, sql and exports
  • visualizations can be exported
  • added pyrestcli dependency to requirements.txt
  • CartoException was accidentally gone
  • Fixed params in constructor call
  • fixed visualization export state options
  • minor changes to work with pyrestcli
  • removing batch manager
  • fix on sending requests to bath sql api
  • Merge pull request #33 from CartoDB/remove-sqlbatchmanager
  • Merge pull request #34 from CartoDB/jsanz-fix-sendsqlbatch
  • Auth and SQL clients store base_url and username, base_url doesn't expect trailing /api anymore
  • Enforce trailing / from base_url
  • Merge pull request #46 from dmed256/1.0.0
  • added ORGANIZATION variable since it is needed for test fixtures
  • Added tests for auth.py
  • Updated README.md with instructions to run tests
  • excludes carto.com/u/ since api endpoints go to . carto.com
  • Fixed malformed named map template JSON
  • Fixed named maps APIs
  • removes unneeded test
  • added API method to instantiate anonymous maps
  • Merge pull request #48 from CartoDB/auth-username-fix
  • moved tests for the SQL API to pytest
  • updated to pyrestcli 0.6.2. This change breaks compatibility with pyrestcli 0.6.1, so you need to upgrade requirements
  • Use pyrestcli's new session argument
  • Merge pull request #51 from dmed256/1.0.0
  • Merged changes in 1.0.0 related to pyrestcli new session parameter
  • fixed file import API and added tests
  • fixes #14
  • Reverting some tests related to file import API since they were already in the datasets manager tests
  • ensuring non existing named maps before creation
  • added myself as a contributor
  • fixes #32
  • Added .idea folder to gitignore
  • Added DS_Store to gitignore
  • Fixes #38
  • Added examples from the examples branch
  • removed old tests
  • Fixed example description
  • Change dataset privacy example
  • Example to export a map as a .carto file
  • Example for creating a named map
  • minor fix
  • Added instantiate map example
  • removed unused code
  • Create anonymous map example
  • Organized examples
  • Adapted to a change in pyrestcli
  • Handling exceptions
  • Added Sphinx API docs
  • Added API docs in README.md
  • Updated README.md
  • Updated requirements and added README.md for the examples folder
  • Merge branch '1.0.0' into 1.0.0-namedmaps
  • Update to version 0.6.3 of pyrestcli
  • Fixed coding style
  • Added local variables to gitignore
  • Fixed coding style
  • Fixed coding style
  • Fixed coding style
  • Fixed coding style
  • Merged changes
  • Fixed a bug when building maps API urls
  • Fixed coding style
  • Added API for downloading map tiles
  • Merge pull request #49 from CartoDB/1.0.0-namedmaps
  • Added warnings when using non-public APIs
  • Updated README.md
  • Added warnings for non-public APIs in the API docs

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CartoDB/carto-python/pull/52, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB1wxagSbFwe-dfrjiVQp0kDIqe-6Tjks5r4r2CgaJpZM4NXoYX .

-- -- CARTO CTO

alrocar commented 7 years ago

About the docs, I think @jsanz proposed publish them at readthedocs (at the moment they are just API docs, not developer documentation yet)

There's no CI integration. Should we go with our own CI server or is it OK with something like travis?

jsanz commented 7 years ago

To publish at readthedocs we don't need any CI service, just configure the webhook on the repo and that's all. I checked and the only concern is that, as you say, the doc folder compiles the API documentation but not the valuable information on the README file in the root. I'll check if there's a way to include it but I wouldn't wait for it for the release.

javisantana commented 7 years ago

we use travis when possible

danicarrion commented 7 years ago

I think we should leave CI out of the equation for now. We're not going to be releasing that often, IMHO.

javisantana commented 7 years ago

I'd not release without CI, that's a min requirement for something "official" (we are leaving a bunch of things but we can live without them ) and it takes a few hours. It's a little effort and helps a lot when getting 3rd party PR

My 2 cents

On Mon, May 15, 2017, 12:53 Dani Carrión notifications@github.com wrote:

I think we should leave CI out of the equation for now. We're not going to be releasing that often, IMHO.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CartoDB/carto-python/pull/52#issuecomment-301442017, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB1w01HEPOFlm6VEQVFIhdtz35Y9zNKks5r6C6QgaJpZM4NXoYX .

-- -- CARTO CTO

javisantana commented 7 years ago

FYI, this is the carto api template doc https://docs.google.com/document/d/14tn8SlFsraodRDcMns5CMYIFsSUs8E3X9OrfrVhCwfY/edit

jsanz commented 7 years ago

I guess you mean using CI for running the tests, right? If docs are automatically set up, I don't see any other place where CI can help on this one.

alrocar commented 7 years ago

Thanks for the doc, I will go through it to see what's pending.

About CI, configuring a job is easy, the issue is that there are some end to end tests, that make actual API requests (with an API key).

Should we use our own CI server instead of Travis?

The other option is to mock all the API requests so we can use the integration of Github and Travis (not sure if this is easy to do...).

Opinions?

javisantana commented 7 years ago

I'd disable those tests on Travis if that's the issue (there is env variables to check if you are running on Travis)

On Mon, May 15, 2017, 13:50 Alberto Romeu notifications@github.com wrote:

Thanks for the doc, I will go through it to see what's pending.

About CI, configuring a job is easy, the issue is that there are some end to end tests, that make actual API requests (with an API key).

Should we use our own CI server instead of Travis?

The other option is to mock all the API requests and use the integration of Github and Travis (not sure if this is easy to do...).

Opinions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CartoDB/carto-python/pull/52#issuecomment-301452634, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB1wyes-b7F1ups4lQ2WNBjl6Xnk-J6ks5r6Dv0gaJpZM4NXoYX .

-- -- CARTO CTO

alrocar commented 7 years ago

Hey @txomon thanks for reviewing. I'll take into account your comments.

alrocar commented 7 years ago

I've taken some time to move forward this PR:

See here the list of done and pending tasks

Comments? @javisantana @danicarrion

danicarrion commented 7 years ago

:heart_eyes:

andy-esch commented 7 years ago

🎉 🎉 🎉