CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

Fix how to handle env vars on examples #70

Closed jsanz closed 6 years ago

jsanz commented 6 years ago

When running examples you are forced to set up environment variables so the arguments parsing is not meaningful. Review the way I'm proposing to handle this (there are other ways) and if you agree, please apply the same workflow to the rest of the examples so they can be run passing the credentials as parameters.

oriolbx commented 6 years ago

Going to apply the same workflow to the rest of examples

jsanz commented 6 years ago

@alrocar, before merging this fix to the examples... do you think there's anything we need to do? like tagging or deploying this to pip later, etc

alrocar commented 6 years ago

Merge and I'll take care. Next time I'll write a document with the steps for publishing a new version:

Thanks!

jsanz commented 6 years ago

@alrocar added those changes, please review :smile:

alrocar commented 6 years ago

🇪🇸

jsanz commented 6 years ago

added a line to the NEWS and merged, all yours @alrocar for update on pip