CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

Visualization Manager fields missing values #72

Closed ztephm closed 6 years ago

ztephm commented 6 years ago

Context

The VisualizationManager lets us access many fields to get information about a CARTO account's maps, but the fields below don't return any information.

Can we update carto-python to return these values? If it's easier to split these into separate issues please let me know

Additional Information

Here's the script I used to test: carto_account_maps_info_all.zip

Here's the dataset generated by the test showing blank fields: maps_all_info2_save

These are all of the available fields:

alrocar commented 6 years ago

Thanks for reporting @ztephm

This is next on the queue, hopefully it will be solved this week :)

alrocar commented 6 years ago

@ztephm I've added support for some of the fields.

Changes are living on this branch maybe you can help me to do the acceptance.

You can install locally that branch with:

pip install -e git+git://github.com/CartoDB/carto-python.git@1.1.3#egg=carto

And then run your script.

Take into account that some of the fields you mentioned (children, delete, get_collection_endpoint, get_id, get_resource_endpoint, etc.) are internal to the carto-python implementation. The ones returned by the viz API are this ones.

Finally, I believe some of the fields are unused and probably will be None or empty.

If you find something wrong please tell me :) Let's see if we can release version 1.1.3 this week.

Thanks

ztephm commented 6 years ago

Thanks @alrocar ! I re-ran the original script & can confirm I'm seeing values returned for the "missing" list (including None).

alrocar commented 6 years ago

Thanks! I will release 1.1.3 tomorrow