search

CartoDB / carto-python

CARTO Python client
https://carto.com
BSD 3-Clause "New" or "Revised" License
154 stars 62 forks source link

adds option for passing custom client id #99

Closed andy-esch closed 5 years ago

andy-esch commented 5 years ago

I'm not sure if this is the best approach, but it seems like a simple way to allow cartoframes (or any other application) to set the client arg. I'm starting to wonder, though, if there should be a different request param that should be set in cartoframes' case, like super_client=cartoframes_v0.8.1 so as not to quash all carto python sdk usage in the logs.

cc @alrocar

alrocar commented 5 years ago

@rafatower would you mind reviewing? See related issue #97

We were thinking on subclassing _ClientIdentifier, but since it's marked as a private class we were unsure if it was a nice solution.

alrocar commented 5 years ago

Thanks @rafatower

@andy-esch Do you need a release of this? If so, you can try to deploy yourself the package by following this guide. Credentials are in Lastpass.

If you are not able, let me know and I'll do the release tomorrow.

andy-esch commented 5 years ago

Thanks @rafatower and @alrocar! I'll try out the deploy.